Wireshark-commits: [Wireshark-commits] master 5ab8490: Qt: Allow multiple lines in the packet list.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ab84900881289546a0aa3beb577af5383898e2e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
5ab8490 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Allow multiple lines in the packet list.
Remove the setUniformRowHeights(true) call in the PacketList
constructor. This means that the packet list now calculates its height
by querying the Qt::SizeHintRole for every item instead of simply
multiplying item_height * number_of_rows.
Implement SizeHintRole in PacketListModel::data so that size
calculations aren't unbearably slow. We don't have any row text until an
item is drawn (via DisplayRole), so items with multiple lines end up
being rendered twice. Note where we make assumptions on line heights.
Although we call gtk_tree_view_set_fixed_height_mode() in the GTK+ UI we
don't have this problem there. GTK+ is apparently less strict about
enforcing row heights.
Bug: 10924
Change-Id: I98e9f4f5f321c2e03f18498e0a7e7556f88792a1
Reviewed-on: https://code.wireshark.org/review/7430
Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 410b40d Export CLIENT_RANDOM with Export SSL Session Keys
adds 5ab8490 Qt: Allow multiple lines in the packet list.
Summary of changes:
ui/qt/packet_list.cpp | 7 +++++--
ui/qt/packet_list_model.cpp | 44 ++++++++++++++++++++++++++++++------------
ui/qt/packet_list_model.h | 15 +++++++++-----
ui/qt/packet_list_record.cpp | 16 +++++++++++++--
ui/qt/packet_list_record.h | 5 ++++-
5 files changed, 65 insertions(+), 22 deletions(-)
