Wireshark-commits: [Wireshark-commits] master 410b40d: Export CLIENT_RANDOM with Export SSL Session
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Mar 2015 16:27:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=410b40d37145ac217db41ea6bc403c36ab53195d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

410b40d by Peter Wu (peter@xxxxxxxxxxxxx):

    Export CLIENT_RANDOM with Export SSL Session Keys
    
    This allows for exporting the SSL session keys for captures which were
    decrypted using a RSA certificate, but where the server does not support
    session resumption.
    
    To avoid frequent reallocations, the expected length is used as initial
    string size.
    
    Tested against a nginx server with ssl_session_cache off.
    
    Note that all keys loaded via ssl.keylog_file are exported, not just the
    displayed ones!
    
    Change-Id: Ie3a93d3692885502f46442953fa53303d16672d7
    Reviewed-on: https://code.wireshark.org/review/7175
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6c1e4d2   http2: improve heuristics, remember conversation
    adds  410b40d   Export CLIENT_RANDOM with Export SSL Session Keys


Summary of changes:
 debian/libwireshark0.symbols       |    1 +
 epan/dissectors/packet-ssl-utils.c |    3 ++
 epan/dissectors/packet-ssl.c       |    6 ++--
 epan/dissectors/packet-ssl.h       |    3 ++
 ui/ssl_key_export.c                |   59 +++++++++++++++++++++++++++---------
 5 files changed, 56 insertions(+), 16 deletions(-)