Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 603878e: Improved deregistering fields.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=603878efd005b5c1bcff548303cfd3aec09a0102
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

603878e by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Improved deregistering fields.
    
    This improvement avoids use of deallocated memory (crash) if using a
    deregistered field in display filter, color filter, custom column and
    other cases when the field is used as "interesting field".
    
    This functionality is currently used in http, imf and ldap preferences.
    
    Change-Id: Idd54adf2f482184eeb89ba8b7211dc49d76f7c96
    Reviewed-on: https://code.wireshark.org/review/5219
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  50c5cac   1.12.4 → 1.12.5
    adds  603878e   Improved deregistering fields.


Summary of changes:
 asn1/ldap/packet-ldap-template.c |    6 +---
 debian/libwireshark5.symbols     |    2 ++
 epan/dissectors/packet-http.c    |    6 +---
 epan/dissectors/packet-imf.c     |    6 +---
 epan/dissectors/packet-ldap.c    |   12 +++----
 epan/proto.c                     |   64 ++++++++++++++++++++++++++++++++++++++
 epan/proto.h                     |   11 ++++++-
 ui/gtk/main.c                    |   33 ++++++++++++++++++++
 ui/gtk/main.h                    |    3 ++
 ui/gtk/uat_gui.c                 |    2 +-
 ui/qt/main_window.cpp            |    2 ++
 ui/qt/main_window.h              |    1 +
 ui/qt/main_window_slots.cpp      |   31 ++++++++++++++++++
 ui/qt/uat_dialog.cpp             |    2 +-
 ui/qt/wireshark_application.cpp  |    3 ++
 ui/qt/wireshark_application.h    |    4 ++-
 16 files changed, 161 insertions(+), 27 deletions(-)