Wireshark-commits: [Wireshark-commits] master-1.10 2f4cbbb: Improved deregistering fields.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Mar 2015 03:59:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f4cbbbbf888b3875ca1c469efd3ea0a3d76f580
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

2f4cbbb by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Improved deregistering fields.
    
    This improvement avoids use of deallocated memory (crash) if using a
    deregistered field in display filter, color filter, custom column and
    other cases when the field is used as "interesting field".
    
    This functionality is currently used in http, imf and ldap preferences.
    
    Change-Id: I1f5b3d0d1eb6d0085a1670768c67085b81bb1aae
    Reviewed-on: https://code.wireshark.org/review/5220
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4463e1b   1.10.13 → 1.10.14.
    adds  2f4cbbb   Improved deregistering fields.


Summary of changes:
 asn1/ldap/packet-ldap-template.c |    6 +---
 epan/dissectors/packet-http.c    |    6 +---
 epan/dissectors/packet-imf.c     |    6 +---
 epan/dissectors/packet-ldap.c    |    8 ++---
 epan/proto.c                     |   66 +++++++++++++++++++++++++++++++++++++-
 epan/proto.h                     |   11 ++++++-
 ui/gtk/main.c                    |   33 +++++++++++++++++++
 ui/gtk/main.h                    |    3 ++
 ui/gtk/uat_gui.c                 |    2 +-
 ui/qt/main_window.cpp            |    2 ++
 ui/qt/main_window.h              |    1 +
 ui/qt/main_window_slots.cpp      |   31 ++++++++++++++++++
 ui/qt/wireshark_application.cpp  |    3 ++
 ui/qt/wireshark_application.h    |    4 ++-
 14 files changed, 157 insertions(+), 25 deletions(-)