Wireshark-commits: [Wireshark-commits] master a22ea3d: gmr1_rach: Update NULL GPS position decoding
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 10:17:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a22ea3dc52b8f19a155fb6e531bf548c05a3046b
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a22ea3d by Sylvain Munaut (tnt@xxxxxxxxxx):

    gmr1_rach: Update NULL GPS position decoding with reality
    
    The spec doesn't always match 100% reality. In this case it seems some
    manufacturer implemented NULL GPS position with longitude.
    
    Change-Id: I0c09627d64814a9467ecbecdc18e43974e4bab4a
    Signed-off-by: Sylvain Munaut <tnt@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/6289
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  a16ac8f   gmr1_rach: Use FT_INT24 instead of FT_UINT24 for latitude/longitude
    adds  a22ea3d   gmr1_rach: Update NULL GPS position decoding with reality


Summary of changes:
 epan/dissectors/packet-gmr1_rach.c |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)