Wireshark-commits: [Wireshark-commits] master a16ac8f: gmr1_rach: Use FT_INT24 instead of FT_UINT24
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 10:14:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a16ac8f306adca88308c74c5b4ab3e2ff8fd5215
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a16ac8f by Sylvain Munaut (tnt@xxxxxxxxxx):

    gmr1_rach: Use FT_INT24 instead of FT_UINT24 for latitude/longitude
    
    No need to do sign extension manually, the core code now supports
    signed integers with bitmask and it will do the sign extension.
    Not sure if that was always the code, but it works now.
    
    This also have the advantage that the real value 'seen' by wireshark
    when applying filters is the real signed value.
    
    Change-Id: I47e2357e5556160a00110ad63e3342879769a0b9
    Signed-off-by: Sylvain Munaut <tnt@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/6288
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  7c9d6ff   Lua: replace proto_tree_add_text calls
    adds  a16ac8f   gmr1_rach: Use FT_INT24 instead of FT_UINT24 for latitude/longitude


Summary of changes:
 epan/dissectors/packet-gmr1_rach.c |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)