Wireshark · Wireshark-commits: [Wireshark-commits] master-1.10 9a2e8ea: sigcomp-udvm: fix invalid access

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a2e8ead5c93e5af78881fb1c0e1ac4d648e2d58
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

9a2e8ea by Evan Huus (eapache@xxxxxxxxx):

    sigcomp-udvm: fix invalid access
    
    Way back in 2006, svn r20041 (now gd408f2f6fc) worked around a problem by
    limiting the amount of buffer dealt with in the udvm_state_access call (changing
    it from state_minimum_access_length_buff[n] to STATE_MIN_ACCESS_LEN).
    
    The very next line however, tries to read the same amount of buffer to display
    to the user - since it seems nobody ever applied a proper fix for the original
    case, just apply the same workaround to the second call.
    
    Bug: 10662
    Change-Id: I32c81ee2a8eb7b30ff7ab1fbbb6ea5f206385d4b
    Reviewed-on: https://code.wireshark.org/review/5125
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 254436c43bdf59250780ff51fe07d1a8d0794ccd)
    Conflicts: epan/sigcomp-udvm.c
    Reviewed-on: https://code.wireshark.org/review/5177
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  034d98e   smb2: fully initialize dummy session
    adds  9a2e8ea   sigcomp-udvm: fix invalid access


Summary of changes:
 epan/sigcomp-udvm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)