Wireshark-commits: [Wireshark-commits] master-1.10 034d98e: smb2: fully initialize dummy session
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Nov 2014 00:07:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=034d98e052842b854a5798764851ff9d8b82be16
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

034d98e by Evan Huus (eapache@xxxxxxxxx):

    smb2: fully initialize dummy session
    
    A few fields weren't being zeroed and were causing valgrind warnings.
    
    Bug: 10569
    Change-Id: I30e1e70c9445376806f385f3578b65bf6e320f8b
    Reviewed-on: https://code.wireshark.org/review/4703
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit d07c65de126f976190f1ce8d07ed8fe7deb90696)
    Conflicts: epan/dissectors/packet-smb2.c
    Reviewed-on: https://code.wireshark.org/review/5178
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7b6e578   tn5220: prevent another potential endless loop exit the loop if dissect_unknown_data() returns 0
    adds  034d98e   smb2: fully initialize dummy session


Summary of changes:
 epan/dissectors/packet-smb2.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)