Wireshark-commits: [Wireshark-commits] master 74e8613: Don't check the checksum if we're encapsulat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Nov 2014 15:52:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74e8613fe17a7588040aedc2d806d3bace75e6ee
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74e8613 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't check the checksum if we're encapsulated in an (ICMP) error packet.
    
    This is the case when an ICMP echo is returned (e.g., because it's too big).
    
    This effectively applies SVN rev 36193 to ICMPv6.
    
    Bug: 10620
    Change-Id: I29aeaabc2467c818714df448e39b3a93027c8961
    Reviewed-on: https://code.wireshark.org/review/5030
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6a37368   Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64
    adds  74e8613   Don't check the checksum if we're encapsulated in an (ICMP) error packet.


Summary of changes:
 epan/dissectors/packet-icmpv6.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)