Wireshark-commits: [Wireshark-commits] master 6a37368: Validate no_of_bits in ws_sign_ext32 and ws_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Nov 2014 15:51:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a3736873831f0fd766f5a482ae01f72a4a3dc49
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6a37368 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64
    
    The result of the '<<' expression is undefined if no_of_bits - 1 is negative.
    
    Change-Id: I3fff09afe414bdd9d6736ee351f1c542c503b93d
    Reviewed-on: https://code.wireshark.org/review/4698
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  54ae596   Translations: Update Polish translation
    adds  6a37368   Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64


Summary of changes:
 wsutil/sign_ext.h |   10 ++++++++++
 1 file changed, 10 insertions(+)