Wireshark-commits: [Wireshark-commits] master a3cecb2: Don't use proto_tree_add_expert() with an it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 19:09:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3cecb290938f56787c0e08b30fc34749bb4baec
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a3cecb2 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use proto_tree_add_expert() with an item rather than a tree.
    
    proto_tree_add_expert() is to be used only on an item that's been
    created as a tree (i.e., an interior node, complete with an ett_ value);
    to hang expert info off of an *item*, which might *not* have been set up
    to take subtree items, use expert_add_info().
    
    Change-Id: Icdcdf39c31c0a03ff80dbb629186e8f6fa82e8ab
    Reviewed-on: https://code.wireshark.org/review/3705
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4a16ffc   Fix handling of STRING16.
    adds  a3cecb2   Don't use proto_tree_add_expert() with an item rather than a tree.


Summary of changes:
 epan/dissectors/packet-acr122.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)