Wireshark-commits: [Wireshark-commits] master 4a16ffc: Fix handling of STRING16.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 18:13:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a16ffc324b5fe6aaea7a9fd6a2e5327f66b0450
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a16ffc by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of STRING16.
    
    When part of a ListOfTextItem, show the STRING16 the same way in both
    places where its value is shown - hex digits or text string.
    
    If the STRING16 contains only 8-bit characters, treat it as ASCII; the
    values 0x20 through 0x7E are *probably* ASCII (although that's not
    guaranteed), but the values above 0x7F aren't guaranteed to be anything.
    *Don't* use tvb_get_ptr() to fetch the string value; that's not
    guaranteed to work with strings.
    
    Don't impose an upper limit on the maximum displayed length of a
    STRING16.
    
    Change-Id: Ia14812335b9afbff695efe5046dc0ffc2483a351
    Reviewed-on: https://code.wireshark.org/review/3704
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8f0d81d   TRILL TREE Sub-TLV fixes
    adds  4a16ffc   Fix handling of STRING16.


Summary of changes:
 epan/dissectors/packet-x11.c |  117 ++++++++++++++++++++----------------------
 1 file changed, 56 insertions(+), 61 deletions(-)