Wireshark-commits: [Wireshark-commits] master 7df03a7: Get rid of debugging output, and get CMake t
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7df03a7c3ec4c89a3f623d00f828bc66ce120ddc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
7df03a7 by Guy Harris (guy@xxxxxxxxxxxx):
Get rid of debugging output, and get CMake to produce verbose makefiles.
On the 32-bit OS X buildbot, automake is old enough that autotools
builds are verbose, printing the command line for each compile step; if
we cause CMake to produce verbose makefiles, they will also print the
command line, so we can see what differences there are.
This means the other debugging output we added isn't necessary; remove
it.
Sort the extra warning options in configure.ac based on whether they're
for C and C++ or just C, just as is the case in CMake, to make it easier
to keep the lists in sync; add comments to configure.ac to mirror the
ones in CMakeLists.txt.
Get rid of -Wno-deprecated-declarations; the CMake build doesn't use it,
and it doesn't appear to be necessary - if we ever have problems with OS
X complaining about using OpenSSL, for example, we should do as tcpdump
does and wrap uses of the "deprecated"-but-cross-platform APIs in
the appropriate pragmas.
Change-Id: I0b8b45f00481ac2b67da5c7dd028a029b130dcc4
Reviewed-on: https://code.wireshark.org/review/3377
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 8d51a50 Remove get_next_di() and just use packet-scope for those
adds 7df03a7 Get rid of debugging output, and get CMake to produce verbose makefiles.
Summary of changes:
CMakeLists.txt | 18 ++++++++++--------
configure.ac | 43 +++++++++++++++++++------------------------
2 files changed, 29 insertions(+), 32 deletions(-)
