Wireshark-commits: [Wireshark-commits] master 8d51a50: Remove get_next_di() and just use packet-sco
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 Aug 2014 08:42:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d51a50a819b293d5bfb95238b9fb11d8789b988
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8d51a50 by Evan Huus (eapache@xxxxxxxxx):

    Remove get_next_di() and just use packet-scope for those
    
    Presumably that was added for tap purposes, but packet-scope is much simpler and
    less dangerous. Noticed while investigating the scan-build issues with
    stack-local variables being pointed to by globals.
    
    Change-Id: I851d756b103df71079b656e624f7472354c15862
    Reviewed-on: https://code.wireshark.org/review/3290
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9112a09   Fix an infinite loop when the line has no length
    adds  8d51a50   Remove get_next_di() and just use packet-scope for those


Summary of changes:
 epan/dissectors/packet-dcerpc.c |   32 ++++++++++----------------------
 1 file changed, 10 insertions(+), 22 deletions(-)