Wireshark-commits: [Wireshark-commits] master 2408297: lua: fix buffer underrun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 May 2014 17:39:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24082972a3650c0e743776b47549a17ab0ad20fe
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2408297 by Peter Wu (peter@xxxxxxxxxxxxx):

    lua: fix buffer underrun
    
    A line containing just "\n" will cause a buffer underrun.
    
    Test:
    tshark -r test/captures/sipmsg.log -X lua_script:test/lua/acme_file.lua -w /dev/null
    
    Caught by ASAN.
    
    Change-Id: Idf38f1af2b211101b3929ee3fbd83c54c99c1e21
    Reviewed-on: https://code.wireshark.org/review/1673
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  cea149a   wiretap: fix regression, missing initialization
    adds  2408297   lua: fix buffer underrun


Summary of changes:
 epan/wslua/wslua_file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)