Wireshark-commits: [Wireshark-commits] master cea149a: wiretap: fix regression, missing initializat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 May 2014 17:22:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cea149aa8916dd9c8b592bb53e5773b3ec141ceb
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cea149a by Peter Wu (peter@xxxxxxxxxxxxx):

    wiretap: fix regression, missing initialization
    
    wtap_dump_open() allocates an empty wtap_dumper struct such that
    interface_data is not initialized. Fix this by adding the member back.
    
    Regression from 3aee917058fb46b2e86d750766001c4db214fc78 ("wiretap:
    remove unused code, drop number_of_interfaces").
    
    Bug: 10113
    Change-Id: Ia6259bf50b25d5e7aa837b0fb7396b07d5d3c72c
    Reviewed-on: https://code.wireshark.org/review/1672
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3aee917   wiretap: remove unused code, drop number_of_interfaces
    adds  cea149a   wiretap: fix regression, missing initialization


Summary of changes:
 wiretap/file_access.c |    1 +
 1 file changed, 1 insertion(+)