Wireshark-commits: [Wireshark-commits] master 85aa071: Get it compiling again: WindowsXP build fail
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Apr 2014 17:51:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=85aa07157a072f6627b019b18ec7e769844f3930
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

85aa071 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Get it compiling again: WindowsXP build failing
    
    The WindowsXP build is failing due to a wslua testsuite failure, in the
    file reader/writer tests. I've looked at it a bit and I don't know
    why it's failing yet - I know why it says it's failing, but it doesn't
    fail for me. And it was passing on WindowsXP until the change to Lua 5.2.3,
    but I run 5.2.3 all the time and it passes for me, and there's nothing
    special about the portion that's failing.
    
    The only way to debug it is to run it on WindowsXP myself, but I need
    a build to do that with, so I've commented out the failing test and
    hopefull it will build now and I can grab the automated build to debug
    the issue.
    
    Change-Id: Ib75e8f75829e8f506823e648605ba16e21c7973a
    Reviewed-on: https://code.wireshark.org/review/982
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6328f6e   Add a couple more in_error_pkt checks.
    adds  85aa071   Get it compiling again: WindowsXP build failing


Summary of changes:
 test/suite-wslua.sh |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)