Wireshark · Wireshark-commits: [Wireshark-commits] master 6328f6e: Add a couple more in_error_pkt checks.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6328f6eb12a47fdf3c6aab3a1dee87a118f2235c
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6328f6e by Jeff Morriss (morriss@xxxxxxxxxxx):

    Add a couple more in_error_pkt checks.
    
    Don't attempt reassembly and squash an expert info when we're in an error
    packet.
    
    Change-Id: I7d19e4ab7add78829bf1e28ad92dce3a7431c37d
    Reviewed-on: https://code.wireshark.org/review/964
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  e60ed4f   IANA assigned port number 6653 to OpenFlow.  However, applications (e.g. opendaylight, nox, openvswitch, etc) still use legacy port numbers.  The most common are 6633 and 6634.  This patch adds a simple heuristic logic and uses the current uint preference as additional input.  In most cases no user intervention is needed and OpenFlow is automatically detected/dissected.
    adds  6328f6e   Add a couple more in_error_pkt checks.


Summary of changes:
 epan/dissectors/packet-sctp.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)