Wireshark-bugs: [Wireshark-bugs] [Bug 10805] Websocket dissector does not find subdissector corr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 30 Dec 2014 16:19:56 +0000

changed bug 10805


What Removed Added
Status IN_PROGRESS RESOLVED
Resolution --- NOTABUG

Comment # 5 on bug 10805 from 
> File packet-websocket.c
> 
> Websocket dissector registered dissector table port_subdissector_table
> 
> 
> port_subdissector_table = register_dissector_table("ws.port",
>       "TCP port for protocols using WebSocket", FT_UINT16, BASE_DEC);
> 
> 
> but no "ws.port" defined in websocket protocol.

That's true. Nobody adds an entry to the table. But it's not a bug.

> When finding subdissector using:
> 
> 
> 
> handle = dissector_get_uint_handle(port_subdissector_table,
> pinfo->match_uint);
> 
> 
> 
> pinfo->match_uint value is not correct.

That's what I thought as well. But I think I was wrong. match_uint is the port
that was used by the previous dissector for selecting websocket. We're using
the same port for finding the next dissector. 

If http is on port 80 and http passed the packet to websocket, we check if an
upper layer protocol registered itselft for websocket payload on port 80.

You are receiving this mail because:
  • You are watching all bug changes.