Wireshark-bugs: [Wireshark-bugs] [Bug 10805] Websocket dissector does not find subdissector corr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 30 Dec 2014 16:14:39 +0000

Comment # 4 on bug 10805 from 
(In reply to Alexis La Goutte from comment #3)
> (In reply to Martin Kaiser from comment #2)
> > I agree that match_uint can't be used here. We should indeed try to match
> > against source or destination port.
> > 
> > I uploaded a change to
> > https://code.wireshark.org/review/#/c/6139/
> > 
> > The capture file from Bug: 6843 can be used to reproduce the issue.
> > 
> > (It isn't a huge problem at the moment as nobody adds a subdissetor to the
> > dissector table.)
> 
> (a wrong copy/paste from packet-http.c ?)

Ohh, I didn't see this one (grep didn't bring it up, the match_uint is on a new
line).

I have to correct my previous comment: The code is very likely correct.

We're trying to match the port that was the match for the *previous* dissector
(e.g. http). If http was called because of port 80 and passed the data on to
websocket, we're using port 80 for our search as well.

Sorry for the noise :-(

You are receiving this mail because:
  • You are watching all bug changes.