Wireshark-bugs: [Wireshark-bugs] [Bug 8849] Buggy IEC104 dissector caused by commit r48958
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 29 Jun 2013 11:08:28 +0000

Comment # 17 on bug 8849 from 
(In reply to comment #15)
> Created attachment 11087 [details]
> Patch for "Fix decoding of CP56time + code style changes v3"
> 
> Hello. I think there a error with definition of month value, because
> mktime() use range between 0 and 11 for month value. Also there small change
> definition of year value.
> 
> P.S. I think, that uses mktime() for output CP56time not good idea in any
> cases, because mktime() return "-1" code if input timestamp will be before 1
> January 1970. I have some *pcap, where timestamp is set to 01.01.70
> 00:31:28. And because my timezone is UTC+4 in this case mktime() return "-1"
> code and in cp56time_tree will be "CP56Time: Not representable".

Year field in CP56Time can take value from 0 to 99. IEC 60870-5-104 was
released at 2000 so why not decode year from 2000 to 2099 instead from 1970 to
2069? This should "solve" your P.S.

You are receiving this mail because:
  • You are watching all bug changes.