Alexis La Goutte
changed
bug 8863
| What |
Removed |
Added |
| Attachment #11092 Flags |
|
review_for_checkin-
|
Comment # 3
on bug 8863
from Alexis La Goutte
Comment on attachment 11092 [details]
Patch to add CAA dissecting to DNS.
Hi,
Look good but need some minor fix :
+static const true_false_string tfs_flags_caa_issuer_critical = {
+ "Critical",
+ "Not critical"
+};
Add this tfs in epan/tfs.[ch] file
+ } else {
+ cur_hf = -1;
+ }
It is not possible to add unknown hf ? ( hf_dns_caa_(issue)_unknown ) and
display in STRING format ?
+ proto_tree_add_text(caa_tree, tvb, cur_offset, 1, "Tag length: %d",
tag_len);
+ proto_tree_add_text(caa_tree, tvb, cur_offset + 1, tag_len, "Tag: %s",
tag);
+ proto_tree_add_text(caa_tree, tvb, cur_offset + 1 + tag_len, value_len,
"Value: %s", value);
Please replace by proto_tree_add_item
+ { &hf_dns_caa_flags,
+ { "CAA Flags", "dns.caa.flags",
+ FT_UINT8, BASE_DEC, NULL, 0,
I prefere display Flags in BASE_HEX
After
+ proto_tree_add_item(caa_tree, hf_dns_caa_flag_issuer_critical, tvb,
cur_offset, 1, ENC_BIG_ENDIAN);
+ cur_offset++;
+
and
+ value_len = data_len - (tag_len + 2);
and
+ FT_BOOLEAN, 8, TFS(&tfs_flags_caa_issuer_critical),
CAA_FLAG_ISSUER_CRITICA
+ NULL, HFILL }},
+
there is some trailing whitespace
You are receiving this mail because:
- You are watching all bug changes.
