Wireshark-bugs: [Wireshark-bugs] [Bug 3290] TRY_TO_FAKE_THIS_ITEM disables bounds errors
Date: Fri, 31 May 2013 02:20:18 +0000

Comment # 25 on bug 3290 from
(In reply to comment #24)
> (In reply to comment #22)
> > Jeff, you seem to have been most involved with this one. Do you have a
> > better idea what will be involved in fixing it? I don't have the time at the
> > moment, but if there's a clear path layed out hopefully somebody will grab
> > it. It would be great to have this done for 1.10.
> 
> Wow, the sad part is this particular bug comment sat in my inbox for the
> longest time because I knew I needed to read it but I really didn't want to
> come back to this bug--I didn't even notice you had specifically asked me
> something.  <sigh> and sorry.

Don't worry about it - the fact that you checked in a fix is a positive far
outweighing any possible delay :)

> Anyway, I checked in part of Didier's patch (attachment 2849 [details]) in
> r49644: this should fix the problem in proto_tree_add_item().  I'll leave
> working on the other APIs until this isn't shown to blow things up.  As
> mentioned in the checkin comment, I'm not sure about back-porting this
> stuff.  We'll have to think about it...

As I mentioned in reply to the commit message, I definitely would like to
backport this once it's confirmed to not cause any obvious problems. Let's keep
that discussion on -dev though.


You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.