Wireshark-bugs: [Wireshark-bugs] [Bug 3290] TRY_TO_FAKE_THIS_ITEM disables bounds errors
Jeff Morriss
changed
bug 3290
What |
Removed |
Added |
Status |
CONFIRMED
|
IN_PROGRESS
|
Comment # 24
on bug 3290
from Jeff Morriss
(In reply to comment #22)
> Jeff, you seem to have been most involved with this one. Do you have a
> better idea what will be involved in fixing it? I don't have the time at the
> moment, but if there's a clear path layed out hopefully somebody will grab
> it. It would be great to have this done for 1.10.
Wow, the sad part is this particular bug comment sat in my inbox for the
longest time because I knew I needed to read it but I really didn't want to
come back to this bug--I didn't even notice you had specifically asked me
something. <sigh> and sorry.
Anyway, I checked in part of Didier's patch (attachment 2849 [details]) in r49644: this
should fix the problem in proto_tree_add_item(). I'll leave working on the
other APIs until this isn't shown to blow things up. As mentioned in the
checkin comment, I'm not sure about back-porting this stuff. We'll have to
think about it...
The above fix combined with the fix in r49645 fix the RPC-based-dissector bug
mentioned in comment 16 (and bug 8728).
You are receiving this mail because:
- You are the assignee for the bug.
- You are watching all bug changes.