Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8691] Adding support of BGP flow spec RFC 5575

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 17 on bug 8691 from Alexis La Goutte

 /*proto_tree_add_text(tree, tvb, offset,
+                            offset_len, "Flow spec NLRI length is %u
Bytes",tot_flow_len)
May be removed ?

+    proto_tree_add_text(nlri_tree, tvb, offset,
+                        offset_len, "NLRI length %u Bytes",tot_flow_len);

Should be replace by proto_tree_add_uint:

+    proto_tree_add_uint(nlri_tree, tvb, offset, hf_bgp_flowspec_nlri_length,
+                        offset_len, tot_flow_len);
?

           proto_tree_add_text(nlri_tree, tvb, offset+cursor_fspec,1,
+                                "NLRI Type unknown
(%u)",tvb_get_guint8(tvb,offset+cursor
Not needed ? 

+                                       
proto_tree_add_text(subtree3,tvb,q+2,6,"Action flags: %s %s %s",
+                                                           
tvb_get_ntohs(tvb,q+6)&0x02 ? "S flag set" : "",
+                                                           
tvb_get_ntohs(tvb,q+6)&0x01 ? "T flag set" : "",
+                                                           
tvb_get_ntohs(tvb,q+6)&0x00 ? "No Flag" : "");
[...]
+                                       
proto_tree_add_text(subtree3,tvb,q+2,6,"Route Target: %u:%u",
+                                                            tvb_get_ntohs(tvb,
q + 2),
+                                                            tvb_get_ntohl(tvb,
q + 4));


Should be replace by proto_tree_add_item (a hf for each flag)

---

      You are receiving this mail because:

• You are watching all bug changes.