Wireshark-bugs: [Wireshark-bugs] [Bug 8691] Adding support of BGP flow spec RFC 5575
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 20 May 2013 15:27:38 +0000

Comment # 16 on bug 8691 from 
Thanks !

The code don't compile under Linux : 
packet-bgp.c:1322:15: error: variable 'ip_length' set but not used
[-Werror=unused-but-set-variable]

And multiple errors about operator variable
packet-bgp.c:1142:12: error: identifier 'operator' conflicts with C++ keyword
[-Werror=c++-compat]
packet-bgp.c:1150:9: error: identifier 'operator' conflicts with C++ keyword
[-Werror=c++-compat]
packet-bgp.c:1151:24: error: identifier 'operator' conflicts with C++ keyword
[-Werror=c++-compat]
....

Also the last arg of proto_tree_add_item is the encoding (ENC_BIG_ENDIAN or
ENC_LITTLE_ENDIAN see README.dev guide)

There is also some trailing whitespace.

There is also a change in doc/README.dev ? a mistake ?

You are receiving this mail because:
  • You are watching all bug changes.