Wireshark-bugs: [Wireshark-bugs] [Bug 8509] Bluetooth: Fix and improve SDP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 29 Mar 2013 19:01:23 +0000

Comment # 19 on bug 8509 from 
Patch 2 looks pretty good. I'm seeing two small issues with it:

- Everywhere you do g_snprintf(str + strpos, MAX_SDP_LEN, *) it should I think
be g_snprintf(str + strpos, MAX_SDP_LEN - strpos, *), since g_snprintf doesn't
otherwise know how much of the beginning of str is being skipped?

- My GCC warns: packet-btsdp.c:1656:29: error: 'value_offset' may be used
uninitialized in this function [-Werror=maybe-uninitialized]

You are receiving this mail because:
  • You are watching all bug changes.