Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8507] UHD Protocol: USRP hardware driver

Wireshark-bugs: [Wireshark-bugs] [Bug 8507] UHD Protocol: USRP hardware driver

Date: Fri, 22 Mar 2013 14:24:36 +0000

Comment # 4 on bug 8507 from Jaap Keuter

Quick review:

ip_addr = tvb_get_ipv4(tvb, offset + 12);
proto_tree_add_ipv4(uhd_tree, hf_uhd_ip_addr, tvb, offset+12, 4, ip_addr);

can become

proto_tree_add_item(uhd_tree, hf_uhd_ip_addr, tvb, offset+12, 4,
ENC_BIG_ENDIAN);

Also, why use 'offset', since it never changes value?

You are receiving this mail because:

You are watching all bug changes.

References:
- [Wireshark-bugs] [Bug 8507] New: UHD Protocol: USRP hardware driver
  - From: bugzilla-daemon

Prev by Date: [Wireshark-bugs] [Bug 8496] Lua doesn't provide all field values when there are multiple fields of the same abbrev
Next by Date: [Wireshark-bugs] [Bug 8510] TShark -x does not show packet summary anymore.
Previous by thread: [Wireshark-bugs] [Bug 8507] UHD Protocol: USRP hardware driver
Next by thread: [Wireshark-bugs] [Bug 8507] UHD Protocol: USRP hardware driver
Index(es):
- Date
- Thread