Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8496] Lua doesn't provide all field values when there are multiple fields of t

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 3 on bug 8496 from Evan Huus

After a few days for reflection, I stand by my analysis. Since nobody else has
expressed an opinion I'm willing at this point to commit the change to reverse
Lua's iteration direction. Is the entirety of the change just the one line:

Index: epan/wslua/wslua_field.c
===================================================================
--- epan/wslua/wslua_field.c    (revision 48476)
+++ epan/wslua/wslua_field.c    (working copy)
@@ -502,7 +502,7 @@
         WSLUA_ERROR(Field__call,"Fields cannot be used outside dissectors or
taps");
     }

-    for (;in;in = in->same_name_next) {
+    for (;in;in = in->same_name_prev) {
         GPtrArray* found = proto_get_finfo_ptr_array(lua_tree->tree, in->id);
         guint i;
         if (found) {

Or is there a little more to it?

---

      You are receiving this mail because:

• You are watching all bug changes.