Wireshark-bugs: [Wireshark-bugs] [Bug 8339] Add support for (USB) variable-length bitmasks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 05 Mar 2013 16:11:15 +0000

changed bug 8339

What Removed Added
Status INCOMPLETE RESOLVED
Resolution --- FIXED

Comment # 10 on bug 8339 from 
(In reply to comment #9)
> > Regarding get_uint_value and get_int_value...
> Your understanding is correct. I would submit a patch to fix these but it
> occurred to me as I started to create it that the get_int_value() case is
> more problematic because of sign extension...which is not addressed by the
> current code either. I think I will leave this for someone with more time to
> address (and test) it properly and enter it as a bug.

Good point - yuck. This is still an error case as far as I know so it's really
not a big deal at least.

> >  bug #7933 is no longer relevant and can be closed?
> I still think there is a place for FT_BYTES with endianness. In the UVC
> dissector there are two places where, because the current implementation has
> no such concept, I had to use proto_tree_add_text() instead. I suppose I
> could work the patch for 7933 into the UVC code without the need for a
> consensus on changing FT_BYTES, but that doesn't seem right to me.

Agreed. We'll see what happens on the bug, and if nobody else comments there
I'll bring it up on -dev for discussion.

Anyways, this one at least can be closed.

You are receiving this mail because:
  • You are watching all bug changes.