Wireshark-bugs: [Wireshark-bugs] [Bug 8431] New Dissector Patch - USB PTP / MTP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 05 Mar 2013 13:49:51 +0000

Comment # 7 on bug 8431 from 
Hi Max,

I was looking over the packet-usb patch, but it won't apply to the latest code
from SVN, so you may need to rebase it.

In packet-usb.h, you define DEV_PRODUCT_UNKNOWN as 0 but the comment next to it
says "0x0000 and 0xffff are used values by vendors"...? If there's not a value
guaranteed to be unused you could take the same tack as interface
class/subclass and use an internal representation that is 4 bytes, and make the
"UNKNOWN" #define have something nonzero in the upper 16 bits.

Re: dissect_usb_interface_descriptor(): "Save older info not from this packet"
-
Technically the device vendor/product ID resides in the same packet as the
interface descriptor (all part of one big happy configuration descriptor).
Might be better to remove that comment and change the one above ("save the
subclass so we can access it later in class-specific descriptors") to "save
information useful to class-specific dissectors".

I think the rest of the packet-usb changes look OK. Haven't had time to look
over the PTP code yet but am glad you're submitting it...could have used it a
few years ago when I was working on a PTP device!

--Steve

You are receiving this mail because:
  • You are watching all bug changes.