Wireshark-bugs: [Wireshark-bugs] [Bug 8082] cisco-sm dissector enhancement
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Dec 2012 21:39:21 +0000

changed bug 8082

What Removed Added
Status UNCONFIRMED IN_PROGRESS
CC   pascal.quantin@gmail.com
Ever confirmed   1

Comment # 2 on bug 8082 from 
Hi,

thanks for your patch. Here are a few comments after a quick review:
- there are a few typo errors to fix (like "Disonnect" for example)
- any reason for not adding a define for each SM PDU type? Because the value is
not used in conditional statements?
- personally I would prefer a "switch case" instead of multiple "else if"
statements. Maybe just a matter of taste
- instead of fetching the same u32 multiple times with
tvb_get_ntohl(tvb,offset), you could store the result in a variable and reuse
it as you suggested. It would avoid some useless processing
- why not use a dedicated hf entry instead of reusing hf_sm_retrieval_type to
dump the BSN?

Some sample captures would be greatly appreciated for the fuzz tester.

You are receiving this mail because:
  • You are watching all bug changes.