Wireshark-bugs: [Wireshark-bugs] [Bug 8082] New: cisco-sm dissector enhancement
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Dec 2012 16:56:53 +0000
Bug ID 8082
Summary cisco-sm dissector enhancement
Classification Unclassified
Product Wireshark
Version SVN
Hardware x86
OS All
Status UNCONFIRMED
Severity Major
Priority Low
Component Wireshark
Assignee bugzilla-admin@wireshark.org
Reporter ojab@ojab.ru 

Created attachment 9678 [details]
patch

Build Information:
wireshark 1.9.0 (SVN Rev 46333 from /trunk)

--
You can find patch for cisco-sm dissector, that greatly enhances Cisco SM SS7
dissection, in the attached file.
It's based on cisco documentation, Yate ciscosm module sources (links can be
found in the patch) and my fuzzing of Cisco AS5350XM + Cisco PGW2200 & Yate.

1. What indent style should be used? Unfortunately I can't find this info in
docs, AFAIU it's per-file (at least in dissectors) and I've tried to use
modeline similar to current indentation.
2. Should I use tmp variable where I'm using tvb_get_ntohl(tvb,offset)?
3. Any comments?

You are receiving this mail because:
  • You are watching all bug changes.