https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
--- Comment #49 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-09-10 03:01:43 PDT ---
Please note that you can continue review, because other patches are not related
to first patch.
(In reply to comment #46)
> Comment on attachment 9071 [details]
> [PATCH 1/4] Bluetooth: Improve internal Decode By channel for RFCOMM
>
> I think the pref_decode_by preference structure would be much better suited as
> a UAT. You could also verify the dissector string names within the UAT in case
> the user makes a typo.
Ok, I will try, but I do not think that this will be much better then my
solution.
With your solution there is possibility to verify the dissector string name,
but with my solution access to fields is faster.
> Or could the dissector names be a dropdown? I assume the list of subdissectors
> is somewhat finite.
No, no, no. Dropdown is not what we want. Dissector to be use on top of RFCOMM
may be freely chosen by user, for example XMPP (maybe someone use it for some
cases). Of course list of dissectors are finite on the world :) But too much to
present then in that form.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
