Wireshark-bugs: [Wireshark-bugs] [Bug 7222] Saving a file may discard comments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 25 May 2012 10:47:15 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7222

--- Comment #9 from Guy Harris <guy@xxxxxxxxxxxx> 2012-05-25 10:47:15 PDT ---
(In reply to comment #6)

> BTW, attachment 8364 [details] figures out if there are packet comments by looking at all
> the frames.  We really need to avoid doing that.  I was thinking of keeping a
> counter somewhere (cfile?) of the number of packets that have comments.

Yes, the capture_file structure is the right place to keep a count of comments.
 (Call it a count of comments - pcap-NG supports multiple comments per packet,
as does the Network Monitor file format, and we should probably support
multiple comments per packet at some point.  Might as well make it 64-bit -
humans are unlikely to add more than 4 billion comments, but a capture tool
could conceivably write a comment or multiple comments on every frame.)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.