Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7222] New: Saving a file may discard comments

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7222

           Summary: Saving a file may discard comments
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: wireshark@xxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Dear all,

when a capture is saved in a file format that does not support comments,
the comments that the user input are discarded without any advance
warning.

You can simply set the default file type to pcap, start a capture, add a
comment and save the file. If you load it again, the comment's gone.

One approach to fix this would be to offer only file formats that support
comments when the user wants to save a file that contains comments.

I've been playing with this a bit, please see the attached patch. The
idea is to run through all frame_data structs and look for comments when
the file is to be saved. In the wiretap filetype array, I added a bool
indicating comment support in a file format.
wtap_get_savable_file_types() does the match between file and file
format.

The patch is not clean (and therefore not marked review_for_checkin ;-). It
does not take into account that the user might only save a part of the file
which might not contain comments.

I believe this issue should be addressed and I'd appreciate your feedback
about the approach.

Thanks,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.