Wireshark-bugs: [Wireshark-bugs] [Bug 7061] New Dissector: Binary Floor Control Protocol (BFCP)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Apr 2012 23:34:15 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7061

--- Comment #17 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-04-18 23:34:14 PDT ---
(In reply to comment #16)
> Ya, it isn't elegant, but in the updated BFCP rfc the 4th bit is the "I" or
> transaction-initiator. So now the options for the first byte are either 0x20 or
> 0x30. I was hacking to get this working.

Then update the comment just before to reflect that both values are now allowed

> Ya, that makes sense. This is my first wireshark plugin dev, and was hacking
> this pretty quick ( as I am at the IMTC SuperOp! right now doing a lot of bfcp
> testing ). What do you recommend for the name?

Why not simply dissect_bfcp? :)

Please also replace
+            int read = 0;
by
+            gint read = 0;

Thanks!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.