Wireshark-bugs: [Wireshark-bugs] [Bug 7145] Add L2TP filter on Control Message AVP value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Apr 2012 23:15:46 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7145

Anders Broman <anders.broman@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-04-18 23:15:46 PDT ---
(In reply to comment #1)
> I have a few questions while posting the diff for this bug.
> 
>     - The original strings were based on the 'calltypestr' array in
> epan/dissectors/packets-l2tp.c.  Is it normal to have the '_' and '-' in the
> name like this?  It might look better if just spaces are used.  Even then, I'm
> not sure it would be OK to change the name here due to anyone expected these
> strings in the output.
> 
I would think the strings has been copied from a spec, it is ok to remove "_"
and "-" and replace with " " I think.
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.