Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6874] New dissector: performance co-pilot protocol

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874

--- Comment #2 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-28 01:44:37 PST ---
Hi,

Quick Review :
Missing modification for Cmake (epan/CmakeFiles.txt)
Use FALSE / TRUE for encoding attribut of proto_tree_add_item is obsolete, you
need to use ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN (there is the fix-encoding-args
tools for help you)
Add also modeline information 

And for finish, there is some Clang Warning : 
packet-pcp.c:526:2: warning: Value stored to 'bits_offset' is never read
packet-pcp.c:1061:2: warning: Value stored to 'bits_offset' is never read
packet-pcp.c:1089:10: warning: Value stored to 'bits_offset' during its
initialization is never read
packet-pcp.c:1140:2: warning: Value stored to 'bits_offset' is never read
packet-pcp.c:1475:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1438:6: warning: Value stored to 'offset' is never read
packet-pcp.c:1483:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1451:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1463:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1447:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1491:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1471:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1459:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1467:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1487:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1455:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1443:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1436:6: warning: Value stored to 'offset' is never read
packet-pcp.c:1428:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1479:5: warning: Value stored to 'offset' is never read
packet-pcp.c:1508:2: warning: Value stored to 'offset' is never read

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.