Wireshark-bugs: [Wireshark-bugs] [Bug 6878] Overhaul of tvb_get_bitsxx() functions
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 28 Feb 2012 01:41:14 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6878

--- Comment #3 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-02-28 01:41:13 PST ---
(In reply to comment #2)
> Oops, you are quite right!, I made a late restructure of those tests (to make
> the code clearer).
> I would be just as happy looping over guint8s, but I thought that taking larger
> chunks might be more efficient (depending on processor and compiler
> architecture).

Yes, but it seems difficult to get it right. Perhaps the added complexity
isn't worth it. I suppose one could use the code from fast_ensure_contiguous()
doing all the checks inside tvb_get_bits() and the access the data directly.
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.