Wireshark-bugs: [Wireshark-bugs] [Bug 6155] Dissector for the USB Integrated Circuit Card Interf
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 15 Nov 2011 13:56:51 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6155

--- Comment #17 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-11-15 13:56:47 PST ---
(In reply to comment #15)
> I do note that the usb-at dissector uses "USB/AT" (I think) for COL_PROTOCOL,
> and "at..." as the filter names.  It seems to me that it would be more
> consistent to also change this dissector to use "USBAT" & "usbat..." instead.

I implemented it that way in a proposed patch submitted in bug 5868.  I thought
maybe one day we could have other dissectors where we'd see AT traffic besides
USB/AT, such as RS232/AT, for example.  But if you think it's better to change
it to USBAT, then I don't have a problem with that.  There's nothing really
"USB" about it though; in fact, we might just change it from packet-usb-at.c to
packet-at.c.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.