Wireshark-bugs: [Wireshark-bugs] [Bug 6155] Dissector for the USB Integrated Circuit Card Interf
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6155
--- Comment #16 from Tyson Key <tyson.key@xxxxxxxxx> 2011-11-14 10:06:52 PST ---
Hi Bill,
Those modifications are fine by me. I was initially aiming for consistency with
the other USB* dissectors - and if I remember correctly, appending "/AT" to
COL_PROTO (instead of just setting it to "AT", or "USBAT") was a suggestion
from Chris Maynard.
Apologies for any unintentional confusion.
Thanks,
Tyson.
(In reply to comment #15)
> A relatively minor question:
>
> This dissector uses "USBCCID" for COL_PROTO and "ccid...." for the filter
> names.
>
> I found this slightly confusing when I tried to filter for "USBCCID" frames in
> a capture since I first assumed that the filter name would be "usbccid".
>
> I note that the usbhid, usbhub and usb-mass-storage dissectors use
> "USBXXX" & etc for COL_PROTO & "usbxxx..." & etc for the filter names.
>
> How would you feel about changing the usb-ccid dissector to use "usbccid..."
> for the filter names ?
>
>
> I do note that the usb-at dissector uses "USB/AT" (I think) for COL_PROTOCOL,
> and "at..." as the filter names. It seems to me that it would be more
> consistent to also change this dissector to use "USBAT" & "usbat..." instead.
>
>
> What are your thoughts ?
>
> Bill
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
