Wireshark-bugs: [Wireshark-bugs] [Bug 6000] [PATCH] Bitcoin dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 7 Jun 2011 01:53:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6000

--- Comment #2 from Christian Svensson <bc@xxxxxxxx> 2011-06-07 01:53:44 PDT ---
(In reply to comment #1)
> Quick review:
> * Use template found in doc/README.developer for file header
> * Don't use " %llu", but use G_GINT64_MODIFIER, as per doc/README.developer
> * Read doc/README.developer...
> * Fuzztest your dissector
> 
> No problem having an incomplete implementation of your dissector. I just should
> not break.

Thanks for the review! I did read the doc/README.developer but it was a while
ago - sorry about that. I will read it again and fuzztest.

Stay tuned.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.