Wireshark-bugs: [Wireshark-bugs] [Bug 5654] dissector for DVB-CI (Common Interface)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
--- Comment #6 from Martin Kaiser <wireshark@xxxxxxxxx> 2011-02-18 11:02:22 PST ---
(In reply to comment #5)
> A few relatively minor comments about the dissector code:
>
> 1. Selecting some of the "tree header" line in the packet-details window
> does not highlight the associated bytes in the packet-bytes window.
>
> E.G:
>
> ti = proto_tree_add_text(tree, tvb, 0, 0, "Application Layer");
>
> If possible, the code should be changed so the the relevant
> bytes are highlighted when the field is selected.
>
> 2. apdu_table is a static table: ie: initialized once and
> never updated.
>
> Altho the actual initialization of apdu_table is done just once, I suggest
> initializing the hash in the proto_register...() since the
> standard usage of register_init_routines fcns is for stuff which needs to
> be initialized for each capture or complete re-dissection.
Hi Bill, all,
I upload a new version of the DVB-CI dissector.
As agreed on the mailing list, I defined a pseudo-header for pcap files that
contain CI captures. The definition is at http://www.kaiser.cx/pcap-dvbci.html
The new dissector uses this format. It fixes the two issues above and some
minor things like typos. The spdu list is now handled in the same way as the
apdu list.
I also upload a new capture file that matches the updated dissector. Apart from
the raw CI data, it also contains hardware events (module inserted/removed
etc).
So far, the blocking issue is getting a DLT value. I sent mails to the
tcpdump-workers list and haven't received any response.
For now, both the code and the sample capture use DLT 237.
As usual, any feedback is welcome. Especially if you can help me to get a DLT.
Best regards,
Martin
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
