Wireshark-bugs: [Wireshark-bugs] [Bug 5654] dissector for DVB-CI (Common Interface)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 11 Feb 2011 09:27:52 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

--- Comment #5 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-02-11 12:27:49 EST ---
A few relatively minor comments about the dissector code:

1. Selecting some of the "tree header" line in the packet-details window
   does not highlight the associated bytes in the packet-bytes window.

   E.G:

      ti = proto_tree_add_text(tree, tvb, 0, 0, "Application Layer");

   If possible, the code should be changed so the the relevant 
   bytes are highlighted when the field is selected.

2. apdu_table is a static table: ie: initialized once and
   never updated.

   Altho the actual initialization of apdu_table is done just once, I suggest
   initializing the hash in the proto_register...() since the
   standard usage of register_init_routines fcns is for stuff which needs to
   be initialized for each capture or complete re-dissection.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.