Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1918] T30 FCF byte decoding masks DTC, CIG and NCS

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1918

--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-11-09 08:17:50 CET ---
(In reply to comment #1)
> You missed a few.  Here are all those with the msb set:
> #define T30_FC_DTC  0x81
> #define T30_FC_CIG  0x82
> #define T30_FC_NSC  0x84
> #define T30_FC_PWD  0x83
> #define T30_FC_SEP  0x85
> #define T30_FC_PSA  0x86
> #define T30_FC_CIA  0x87
> #define T30_FC_ISP  0x88

Yes, the code evolves, so does the bug.

> Only the last 2 are not a case target of the switch ... but maybe they should
> be?  (The msb of "the 'octet'" is also masked in other places before the
> switch.)

Could be.

> Maybe someone who knows this protocol could have a look at it and compare it
> against the spec?: http://www.itu.int/rec/T-REC-T.30-200509-I/en

Yep.

> By the way Jaap, the URL you listed is now broken.  I guess URL's sometimes
> change in 3 years. :)

Really? ;) 
It was a nice overview showing the protocol.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.