Wireshark-bugs: [Wireshark-bugs] [Bug 1918] T30 FCF byte decoding masks DTC, CIG and NCS
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 8 Nov 2010 20:42:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1918

--- Comment #1 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-11-08 20:42:27 PST ---
You missed a few.  Here are all those with the msb set:
#define T30_FC_DTC  0x81
#define T30_FC_CIG  0x82
#define T30_FC_NSC  0x84
#define T30_FC_PWD  0x83
#define T30_FC_SEP  0x85
#define T30_FC_PSA  0x86
#define T30_FC_CIA  0x87
#define T30_FC_ISP  0x88

Only the last 2 are not a case target of the switch ... but maybe they should
be?  (The msb of "the 'octet'" is also masked in other places before the
switch.)

Maybe someone who knows this protocol could have a look at it and compare it
against the spec?: http://www.itu.int/rec/T-REC-T.30-200509-I/en

By the way Jaap, the URL you listed is now broken.  I guess URL's sometimes
change in 3 years. :)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.