Wireshark-bugs: [Wireshark-bugs] [Bug 3934] Need to support QNX' QNET protocol
Date: Wed, 27 Jan 2010 11:53:37 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934

dragonlinux@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4000|review_for_checkin?         |
               Flag|                            |
   Attachment #4000|0                           |1
        is obsolete|                            |
   Attachment #4207|                            |review_for_checkin?
               Flag|                            |

--- Comment #10 from dragonlinux@xxxxxxxxx 2010-01-27 11:53:33 PST ---
Created an attachment (id=4207)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4207)
amended patch

Remove deprecated "if (check_col(pinfo->cinfo, COL_INFO))" checks.
Remove "(void)pinfo;", use ", packet_info * pinfo _U_" instead.
drop the "goto out" statements, which only result in a "return ret".
Don't access "qnet6_type_vals[qtype].strptr", but use val_to_str().

for tvb_get_ptr, I have tried to not using it too frequently and all these have
protections.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.