Wireshark-bugs: [Wireshark-bugs] [Bug 3934] Need to support QNX' QNET protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 24 Jan 2010 08:23:32 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934

--- Comment #9 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-01-24 17:23:26 CET ---
Please refrain from using tvb_get_ptr(), you need the memory protection.
Remove deprecated "if (check_col(pinfo->cinfo, COL_INFO))" checks.
Remove "(void)pinfo;", use ", packet_info * pinfo _U_" instead.
Please drop the "goto out" statements, which only result in a "return ret".
Don't access "qnet6_type_vals[qtype].strptr", but use val_to_str().

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.