Wireshark-bugs: [Wireshark-bugs] [Bug 2675] segmentation fault loading trace containing NCP pack
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 27 Jul 2008 21:28:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2675





--- Comment #20 from Bill Meier <wmeier@xxxxxxxxxxx>  2008-07-27 21:28:54 PDT ---
(In reply to comment #14)
> Created an attachment (id=2062)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2062) [details]
> get_string behavior modification
> 
> The attached patch modifies get_string() to return an ep_allocated buffer
> instead of depending on the caller to provide a preallocated buffer. It also
> removes the nw_uni_t data type, since it's no longer needed.
> 

I've reviewed the patch submitted by Gerald and done some testing. 
1. Fixed: a few cases wherein the string returned by get_string would not be
displayed.

2. Changed: I removed the use of string buffers in several cases since they are
no longer needed with the get_string change.

I've taken the liberty of marking Gerald's original patch as obsolete and
attaching v2 of the patch with the additional fixes/changes.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.